Skip to content

Fix context within listByPrincipalType role method [2.x] - #2944

Merged
bajtos merged 1 commit into
2.xfrom
feature/role-context-2x
Nov 15, 2016
Merged

bajtos merged 1 commit into
2.xfrom
feature/role-context-2x

Conversation

@bajtos

@bajtos bajtos commented Nov 15, 2016

Copy link
Copy Markdown
Member

Fix for current implementation that returned all models that had any assigned roles. Context was not carried into listByPrincipalType, setting roleId as null.

Back-port of #2742

cc @codyolsen

@bajtos bajtos self-assigned this Nov 15, 2016
@bajtos bajtos added the #review label Nov 15, 2016
@bajtos bajtos changed the title Fix context within listByPrincipalType role method Fix context within listByPrincipalType role method [2.x] Nov 15, 2016
- Fix for current implimentation that returned all models that had any
  assigned roles. Context was not carried into listByPrincipalType,
  setting roleId as null.
@bajtos
bajtos force-pushed the feature/role-context-2x branch from 3b5c65e to d99d608 Compare November 15, 2016 15:28
@bajtos

bajtos commented Nov 15, 2016

Copy link
Copy Markdown
Member Author

@slnode test please

@bajtos

bajtos commented Nov 15, 2016

Copy link
Copy Markdown
Member Author

I am going to ignore cis-jenkins build failures as they seem to be intermittent and not related to this patch.

> loopback@2.36.0 test /home/jenkins/workspace/nb/loopback~2.x/8c468a94
> grunt mocha-and-karma

Loading "jscs.js" tasks...ERROR
>> Error: Cannot find module 'cst'
Warning: Task "jscs" not found.� Use --force to continue.

@bajtos
bajtos merged commit 007b20d into 2.x Nov 15, 2016
@bajtos
bajtos deleted the feature/role-context-2x branch November 15, 2016 15:59
@bajtos bajtos removed the #review label Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants